This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Implement evaluateJavascript method for Cordova 6 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * Not exposed outside of the package. | ||
| */ | ||
| interface XWalkCordova6Interface { |
There was a problem hiding this comment.
It's too complex to keep compatibility with adding new interface. It's better removing the annotation "Override" and adding annotation manually like below
/**
* This API is used in Cordova-Android 6.0.0 override from
* CordovaWebViewEngine.java
* @SInCE Cordova 6.0
*/
public void evaluateJavascript(String js, ValueCallback callback) {
webView.evaluateJavascript(js, callback);
}
There was a problem hiding this comment.
Ah, that definitely simplifies things. I'll update the PR with that change :)
|
@fujunwei Updated. Thanks for the review! :) |
|
Thanks, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for Cordova-Android v6 compatibility with the new (threadsafe) bridge method: apache/cordova-android#320